Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): Biodiesel Fuel for Gasoline Engines #3716

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Nov 18, 2023

Purpose of change

IRL, gasoline powered engines can be modified to accept alcohol as fuel. It had been discussed some time ago that making ingame gas engines able to use ethanol would be acceptable.

Describe the solution

Gasoline powered engines now are able to use ethanol, methanol, and denatured alcohol as fuel.

Describe alternatives you've considered

Testing

I've tested it ingame myself, the fix was quick and easy and works fine. Ethanol already had a fuel efficiency number, and methanol and denatured alcohol used copy-from from Ethanol, so it plugged in just fine.

Additional context

Checklist

Made gasoline and JP8 engines capable of using ethanol, methanol, and denatured alcohol as fuel.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 18, 2023
@scarf005 scarf005 self-assigned this Nov 18, 2023
scarf005
scarf005 previously approved these changes Nov 18, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

wish it could run on vodka

@KheirFerrum
Copy link
Collaborator

KheirFerrum commented Nov 18, 2023

I think making it use alcohols is a bad solution in that it trivializes fuel sourcing and makes bio-diesel essentially obsolete, as bio-diesel is the further processed form of alcohol specifically for fuel usage. In this case, I'd say we eschew realism and make gasoline engines also run off bio-diesel, to prevent gasoline from becoming the new best option by a landslide because you can loot alcohol everywhere, and process the base materials into the above options without much work.

Diesel engines will still be better than gasoline engines by dint of being more efficient, but this way it both solves the issue of gasoline engines not having alternatives the player can source while also not turning gasoline engines into a no-brainer "best" option, especially considering that most engines in the game are gasoline engines.

@scarf005 scarf005 changed the title feat(content): Alcohol Fuel for Gasoline Engines feat(content): Biodiesel Fuel for Gasoline Engines Nov 19, 2023
@scarf005 scarf005 added this pull request to the merge queue Nov 19, 2023
Merged via the queue into cataclysmbnteam:upload with commit 1de404e Nov 19, 2023
12 checks passed
@YeOldeMiller
Copy link
Contributor

YeOldeMiller commented Nov 19, 2023

Not sure I like the idea of using biodiesel. Burning ethanol in stock unmodified gas engines may be an acceptable stretch, but this is downright unrealistic.

And as for using spirits being unbalanced: sure you can find them everywhere, but in what quantities? If we're talking about regular alcohol, it still needs to be distilled to make usable, greatly reducing the initial volume. Biodiesel, on the other hand, is 100% processed fat. Alcohol is used in its production as a reagent, not as a burnable substance, and in relatively small quantities. Personally I'd still prefer using biodiesel even with ethanol as readily available fuel because of how much easier it is to source large amounts of oils/fats.

EDIT: while I endorse the initial idea of enabling use of distilled spirits as fuel, methanol should not be included as it is corrosive and should not be used in combustion engines. So, only ethanol should really be usable, making the whole thing even less of a balancing concern.

@chaosvolt
Copy link
Member

Worth noting that while plain alcohol is in abundanance, ethanol takes additional time, resources, and tools to set up.

It also has like half the fuel value of biodiesel: https://github.com/cataclysmbnteam/Cataclysm-BN/blob/upload/data/json/items/fuel.json#L21

I would say that should've been a reasonable tradeoff for the method to make it being overall simpler (but not really dead simple) than biodiesel.

@Unrepentant-Atheist
Copy link

Unrepentant-Atheist commented Nov 20, 2023

Makes this mods obsolete, no? https://github.com/Valikdu/Valik_Vehicle_Expansion , at least the ethanol engines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants